fix(flow-php/symfony-telemetry-bundle): align messenger span naming with OTEL convention#2464
Merged
Merged
Conversation
…ith OTEL convention
- name spans `{operation} {message}` (send/process)
- set operation.name to the operation verb, not the message class
- use message class as destination.name, move bus to
messaging.symfony.bus
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2464 +/- ##
============================================
+ Coverage 85.09% 85.14% +0.04%
- Complexity 4 21259 +21255
============================================
Files 1605 1605
Lines 65588 65589 +1
============================================
+ Hits 55814 55847 +33
+ Misses 9774 9742 -32 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
flow-php/symfony-telemetry-bundle- messenger span name now follows OTEL{operation} {message}conventionflow-php/symfony-telemetry-bundle-messaging.operation.namenow holds the operation verb, destination is the message class, bus moved tomessaging.symfony.busRemoved
Deprecated
Security